- The eureka instance auto registration also changes the secure port when the server port is random (0)

Fixes gh-2303

fixes gh-2386

See https://github.com/spring-cloud/spring-cloud-commons/issues/265

Port information was missing from data sent to eureka.

fixes gh-2372

fixes gh-2216

* Remove @EnableDiscoveryClient and @EnableEurekaClient as there are now optional.  Fixes #2241.

This moves the lifecycle of the eureka client of of EurekaServiceRegistry.

fixes gh-2099

Fixes gh-1849

Needed in `EurekaClientConfigBean` because `CloudEurekaTransportConfig` is a separate class.

Fixes gh-2138

Signed-off-by: Gregor Zurowski <gregor@zurowski.org>

Signed-off-by: Gregor Zurowski <gregor@zurowski.org>

Signed-off-by: Gregor Zurowski <gregor@zurowski.org>

fixes gh-1795

Fixes a race condition introduced in 1.3.0

fixes gh-1933

Ribbon client configuration based on Eureka is disabled if eureka.client.enabed is set to false.

Fixes gh-335

Make EurekaDiscoveryClient.EurekaServiceInstance constructor public

fixes gh-1792

prefer-ip-address does not work in statusPageUrlPath when management port != server port

This change gets `prefer-ip-address` via a relaxed property resolver to set the value during the creation of the `EurekaInstanceConfigBean`.

fixes gh-1724

s-c-commons creates an AutoServiceRegistrationProperties bean if enabled.

This commit only auto registers with eureka if that bean is available.

Defaults were set too late and were overriding values set in the environment.

Specifically, spring.application.name took precedence over eureka.instance.appname.

 fixes gh-1516

Specifically, add `@ConditionalOnBean(EurekaClient.class)`.

Fixes an issue where eureka and ribbon are on the classpath, eureka.client.enabled=false which would cause a bean not found exception.

fixes gh-1511

(cherry picked from commit d1f8c031)

Use the new ServiceRegistry interface

Creates a new EurekaRegistration object that aggregates classes needed
for a single registration.