Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
S
spring-cloud-netflix
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
spring-cloud-netflix
Commits
d4330967
Commit
d4330967
authored
Oct 08, 2015
by
Spencer Gibb
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #577 from alexVengrovsk/master
* pull577: Use instanceof for better readability
parents
8147b7de
e4b63a5b
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
5 deletions
+3
-5
SpringMvcContract.java
...mework/cloud/netflix/feign/support/SpringMvcContract.java
+3
-5
No files found.
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/support/SpringMvcContract.java
View file @
d4330967
...
...
@@ -128,9 +128,7 @@ public class SpringMvcContract extends Contract.BaseContract {
boolean
isHttpAnnotation
=
false
;
// TODO: support spring parameter annotations?
for
(
Annotation
parameterAnnotation
:
annotations
)
{
Class
<?
extends
Annotation
>
annotationType
=
parameterAnnotation
.
annotationType
();
if
(
annotationType
==
PathVariable
.
class
)
{
if
(
parameterAnnotation
instanceof
PathVariable
)
{
String
name
=
PathVariable
.
class
.
cast
(
parameterAnnotation
).
value
();
checkState
(
emptyToNull
(
name
)
!=
null
,
"PathVariable annotation was empty on param %s."
,
paramIndex
);
...
...
@@ -143,7 +141,7 @@ public class SpringMvcContract extends Contract.BaseContract {
data
.
formParams
().
add
(
name
);
}
}
else
if
(
annotationType
==
RequestParam
.
class
)
{
else
if
(
parameterAnnotation
instanceof
RequestParam
)
{
String
name
=
RequestParam
.
class
.
cast
(
parameterAnnotation
).
value
();
checkState
(
emptyToNull
(
name
)
!=
null
,
"QueryParam.value() was empty on parameter %s"
,
paramIndex
);
...
...
@@ -153,7 +151,7 @@ public class SpringMvcContract extends Contract.BaseContract {
nameParam
(
data
,
name
,
paramIndex
);
isHttpAnnotation
=
true
;
}
else
if
(
annotationType
==
RequestHeader
.
class
)
{
else
if
(
parameterAnnotation
instanceof
RequestHeader
)
{
String
name
=
RequestHeader
.
class
.
cast
(
parameterAnnotation
).
value
();
checkState
(
emptyToNull
(
name
)
!=
null
,
"HeaderParam.value() was empty on parameter %s"
,
paramIndex
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment