Skip to content

S
spring-cloud-netflix
Commit 914fee9a by alexVengrovsk Committed by Spencer Gibb
Options

Add isDebugEnabled() check

It is good thing to make this checks because of expensive concatenation of String objects (debug messages).
parent a3a7c609
Showing with 12 additions and 6 deletions
spring-cloud-netflix-eureka-server/src/main/java/org/springframework/cloud/netflix/eureka/server/event/LeaseManagerMessageBroker.java
......@@ -45,8 +45,10 @@ public class LeaseManagerMessageBroker implements LeaseManagerLite<InstanceInfo>
@Override
public void register(InstanceInfo info, int leaseDuration, boolean isReplication) {
log.debug("register " + info.getAppName() + ", vip " + info.getVIPAddress()
+ ", leaseDuration " + leaseDuration + ", isReplication " + isReplication);
if (log.isDebugEnabled()) {
log.debug("register " + info.getAppName() + ", vip " + info.getVIPAddress()
+ ", leaseDuration " + leaseDuration + ", isReplication " + isReplication);
}
// TODO: what to publish from info (whole object?)
this.ctxt.publishEvent(new EurekaInstanceRegisteredEvent(this, info,
leaseDuration, isReplication));
......@@ -54,8 +56,10 @@ public class LeaseManagerMessageBroker implements LeaseManagerLite<InstanceInfo>
@Override
public boolean cancel(String appName, String serverId, boolean isReplication) {
log.debug("cancel " + appName + " serverId " + serverId + ", isReplication {}"
+ isReplication);
if (log.isDebugEnabled()) {
log.debug("cancel " + appName + " serverId " + serverId + ", isReplication {}"
+ isReplication);
}
this.ctxt.publishEvent(new EurekaInstanceCanceledEvent(this, appName, serverId,
isReplication));
return false;
......@@ -64,8 +68,10 @@ public class LeaseManagerMessageBroker implements LeaseManagerLite<InstanceInfo>
@Override
public boolean renew(final String appName, final String serverId,
boolean isReplication) {
log.debug("renew " + appName + " serverId " + serverId + ", isReplication {}"
+ isReplication);
if (log.isDebugEnabled()) {
log.debug("renew " + appName + " serverId " + serverId + ", isReplication {}"
+ isReplication);
}
List<Application> applications = PeerAwareInstanceRegistryImpl.getInstance()
.getSortedApplications();
for (Application input : applications) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment