Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
S
spring-cloud-netflix
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
spring-cloud-netflix
Commits
5613e481
Commit
5613e481
authored
Apr 27, 2016
by
Sébastien PERALTA
Committed by
Dave Syer
Apr 28, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Append to X-Forwarded-Prefix in case it already exists
Fixes gh-993
parent
3a251e2a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
34 additions
and
1 deletion
+34
-1
PreDecorationFilter.java
...k/cloud/netflix/zuul/filters/pre/PreDecorationFilter.java
+12
-1
PreDecorationFilterTests.java
...ud/netflix/zuul/filters/pre/PreDecorationFilterTests.java
+22
-0
No files found.
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/pre/PreDecorationFilter.java
View file @
5613e481
...
...
@@ -114,7 +114,18 @@ public class PreDecorationFilter extends ZuulFilter {
ctx
.
addZuulRequestHeader
(
ZuulHeaders
.
X_FORWARDED_PROTO
,
ctx
.
getRequest
().
getScheme
());
if
(
StringUtils
.
hasText
(
route
.
getPrefix
()))
{
ctx
.
addZuulRequestHeader
(
"X-Forwarded-Prefix"
,
route
.
getPrefix
());
String
existingPrefix
=
ctx
.
getRequest
().
getHeader
(
"X-Forwarded-Prefix"
);
StringBuilder
newPrefixBuilder
=
new
StringBuilder
();
if
(
StringUtils
.
hasLength
(
existingPrefix
))
{
if
(
existingPrefix
.
endsWith
(
"/"
)
&&
route
.
getPrefix
().
startsWith
(
"/"
))
{
newPrefixBuilder
.
append
(
existingPrefix
,
0
,
existingPrefix
.
length
()
-
1
);
}
else
{
newPrefixBuilder
.
append
(
existingPrefix
);
}
}
newPrefixBuilder
.
append
(
route
.
getPrefix
());
ctx
.
addZuulRequestHeader
(
"X-Forwarded-Prefix"
,
newPrefixBuilder
.
toString
());
}
String
xforwardedfor
=
ctx
.
getRequest
().
getHeader
(
"X-Forwarded-For"
);
String
remoteAddr
=
ctx
.
getRequest
().
getRemoteAddr
();
...
...
spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/zuul/filters/pre/PreDecorationFilterTests.java
View file @
5613e481
...
...
@@ -107,6 +107,28 @@ public class PreDecorationFilterTests {
}
@Test
public
void
prefixRouteWithPrefixHeaderConcatsHeader
()
throws
Exception
{
this
.
properties
.
setPrefix
(
"/api"
);
this
.
properties
.
setStripPrefix
(
true
);
this
.
request
.
setRequestURI
(
"/api/foo/1"
);
this
.
request
.
setRemoteAddr
(
"5.6.7.8"
);
this
.
request
.
addHeader
(
"X-Forwarded-For"
,
"1.2.3.4"
);
this
.
request
.
addHeader
(
"X-Forwarded-Prefix"
,
"/prefix"
);
this
.
routeLocator
.
addRoute
(
new
ZuulRoute
(
"foo"
,
"/foo/**"
,
"foo"
,
null
,
false
,
null
,
null
));
this
.
filter
.
run
();
RequestContext
ctx
=
RequestContext
.
getCurrentContext
();
assertEquals
(
"/foo/1"
,
ctx
.
get
(
"requestURI"
));
assertEquals
(
"localhost"
,
ctx
.
getZuulRequestHeaders
().
get
(
"x-forwarded-host"
));
assertEquals
(
"80"
,
ctx
.
getZuulRequestHeaders
().
get
(
"x-forwarded-port"
));
assertEquals
(
"http"
,
ctx
.
getZuulRequestHeaders
().
get
(
"x-forwarded-proto"
));
assertEquals
(
"/prefix/api"
,
ctx
.
getZuulRequestHeaders
().
get
(
"x-forwarded-prefix"
));
assertEquals
(
"1.2.3.4, 5.6.7.8"
,
ctx
.
getZuulRequestHeaders
().
get
(
"x-forwarded-for"
));
assertEquals
(
"foo"
,
getHeader
(
ctx
.
getOriginResponseHeaders
(),
"x-zuul-serviceid"
));
}
@Test
public
void
forwardRouteAddsLocation
()
throws
Exception
{
this
.
properties
.
setPrefix
(
"/api"
);
this
.
properties
.
setStripPrefix
(
true
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment