Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
S
spring-cloud-netflix
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
spring-cloud-netflix
Commits
444f3c80
Commit
444f3c80
authored
Mar 19, 2015
by
Dave Syer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Feign client builder should not assume all annotations are the same
Simple solution is to check for instanceof before casting. Fixes gh-265
parent
b03b2f56
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
0 deletions
+4
-0
SpringMvcContract.java
...mework/cloud/netflix/feign/support/SpringMvcContract.java
+3
-0
FeignClientValidationTests.java
...cloud/netflix/feign/valid/FeignClientValidationTests.java
+1
-0
No files found.
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/feign/support/SpringMvcContract.java
View file @
444f3c80
...
...
@@ -45,6 +45,9 @@ public class SpringMvcContract extends Contract.BaseContract {
@Override
protected
void
processAnnotationOnMethod
(
MethodMetadata
data
,
Annotation
methodAnnotation
,
Method
method
)
{
if
(!(
methodAnnotation
instanceof
RequestMapping
))
{
return
;
}
RequestMapping
mapping
=
RequestMapping
.
class
.
cast
(
methodAnnotation
);
if
(
mapping
!=
null
)
{
// HTTP Method
...
...
spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/feign/valid/FeignClientValidationTests.java
View file @
444f3c80
...
...
@@ -46,6 +46,7 @@ public class FeignClientValidationTests {
@FeignClient
(
"foo"
)
interface
Client
{
@RequestMapping
(
method
=
RequestMethod
.
GET
,
value
=
"/"
)
@Deprecated
String
get
();
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment