Fix codacy issues

spring-boot-admin-server-ui-activiti/src/main/resources/META-INF/spring-boot-admin-server-ui/applications-activiti/module.js

@@ -91,4 +91,4 @@
             }
         });
     }]);
-})(sbaModules, angular);
+} (sbaModules, angular));

spring-boot-admin-server-ui-hystrix/webpack.config.js

@@ -23,7 +23,7 @@ module.exports = {
       'hystrix/hystrixCommand.css': path.resolve(ROOT, 'target/hystrix-dashboard/components/hystrixCommand/hystrixCommand.css'),
       'hystrix/hystrixThreadPool': path.resolve(ROOT, 'target/hystrix-dashboard/components/hystrixThreadPool/hystrixThreadPool.js'),
       'hystrix/hystrixThreadPool.css': path.resolve(ROOT, 'target/hystrix-dashboard/components/hystrixThreadPool/hystrixThreadPool.css'),
-      'tsort' : path.resolve(ROOT, 'target/hystrix-dashboard/js/jquery.tinysort.min.js')
+      'tsort': path.resolve(ROOT, 'target/hystrix-dashboard/js/jquery.tinysort.min.js')
     }
   },
   module: {
@@ -36,7 +36,7 @@ module.exports = {
       {
         test: /hystrix-dashboard\/js\/jquery\.tinysort\.min\.js$/,
         loader: 'imports?jQuery=jquery'
-      },{
+      }, {
         test: /hystrix-dashboard\/components\/hystrixCommand\/hystrixCommand\.js$/,
         loaders: [
           'imports?this=>global&jQuery=jquery&$=jquery&d3&tmpl=microtemplates&tsort',
@@ -49,7 +49,7 @@ module.exports = {
           'imports?this=>global&jQuery=jquery&$=jquery&d3&tmpl=microtemplates&tsort',
           'exports?HystrixThreadPoolMonitor',
           'regexp-replace?{"match": { "pattern": "\.\./components/hystrixThreadPool", "flags": "g" }, "replaceWith": "applications-hystrix/components/hystrixThreadPool"}'
-        ],
+        ]
       }, {
         test: /\.js$/,
         exclude: [/node_modules/],
@@ -72,14 +72,14 @@ module.exports = {
       to: 'applications-hystrix',
       context: 'src/'
     }, {
-        from: '**/*.html',
-        to: 'applications-hystrix/components',
-        context: 'target/hystrix-dashboard/components'
-      }, {
-        from: '**/*.png',
-        to: 'applications-hystrix/components',
-        context: 'target/hystrix-dashboard/components'
-      }
+      from: '**/*.html',
+      to: 'applications-hystrix/components',
+      context: 'target/hystrix-dashboard/components'
+    }, {
+      from: '**/*.png',
+      to: 'applications-hystrix/components',
+      context: 'target/hystrix-dashboard/components'
+    }
     ], { ignore: ['*.tpl.html'] })
   ],
   devServer: {

spring-boot-admin-server-ui/modules/applications-jmx/components/javaTypeInput.js

@@ -59,7 +59,7 @@ module.exports = {
           default:
             return null;
         }
-      })();
+      } ());
 
       ctrl.isObject = ctrl.selectOptions === null && ctrl.inputType === null;
     };

spring-boot-admin-server-ui/webpack.config.js

@@ -81,7 +81,7 @@ module.exports = {
     loaders: [
       {
         test: /^jolokia$/,
-        loader: "imports?$=jquery"
+        loader: 'imports?$=jquery'
       }, {
         test: /\.js$/,
         exclude: [/node_modules/, /third-party/],
@@ -127,11 +127,10 @@ module.exports = {
       from: '**/*.html',
       context: 'core/'
     }, {
-        from: '**/*.html',
-        context: 'modules/'
-      }], {
-        ignore: ['*.tpl.html']
-      })
+      from: '**/*.html',
+      context: 'modules/'
+    }],
+      { ignore: ['*.tpl.html'] })
   ].concat(!isDevServer ? [] : new ModuleConcatPlugin([
     {
       filename: 'all-modules.js',
@@ -145,9 +144,9 @@ module.exports = {
   ])),
   devServer: {
     proxy: [{
-        context: '/api',
-        target: 'http://localhost:8080',
-        secure: false
+      context: '/api',
+      target: 'http://localhost:8080',
+      secure: false
     }]
   },
   node: {

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/config/NotifierConfiguration.java

@@ -51,7 +51,7 @@ public class NotifierConfiguration {
 	@ConditionalOnBean(Notifier.class)
 	public static class NotifierListenerConfiguration {
 		@Autowired
-		public Notifier notifier;
+		private Notifier notifier;
 
 		@Bean
 		@ConditionalOnMissingBean

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/notify/AbstractStatusChangeNotifier.java

@@ -31,7 +31,7 @@ public abstract class AbstractStatusChangeNotifier extends AbstractEventNotifier
 	 * List of changes to ignore. Must be in Format OLD:NEW, for any status use * as wildcard, e.g.
 	 * *:UP or OFFLINE:*
 	 */
-	protected String[] ignoreChanges = { "UNKNOWN:UP" };
+	private String[] ignoreChanges = { "UNKNOWN:UP" };
 
 	@Override
 	protected boolean shouldNotify(ClientApplicationEvent event) {

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/notify/HipchatNotifier.java

@@ -33,7 +33,7 @@ import de.codecentric.boot.admin.event.ClientApplicationStatusChangedEvent;
  * @author Jamie Brown
  */
 public class HipchatNotifier extends AbstractStatusChangeNotifier {
-	private final static String DEFAULT_DESCRIPTION = "<strong>#{application.name}</strong>/#{application.id} is <strong>#{to.status}</strong>";
+	private static final String DEFAULT_DESCRIPTION = "<strong>#{application.name}</strong>/#{application.id} is <strong>#{to.status}</strong>";
 
 	private final SpelExpressionParser parser = new SpelExpressionParser();
 	private RestTemplate restTemplate = new RestTemplate();

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/notify/MailNotifier.java

@@ -33,8 +33,8 @@ import de.codecentric.boot.admin.event.ClientApplicationEvent;
  * @author Johannes Edmeier
  */
 public class MailNotifier extends AbstractStatusChangeNotifier {
-	private final static String DEFAULT_SUBJECT = "#{application.name} (#{application.id}) is #{to.status}";
-	private final static String DEFAULT_TEXT = "#{application.name} (#{application.id})\nstatus changed from #{from.status} to #{to.status}\n\n#{application.healthUrl}";
+	private static final String DEFAULT_SUBJECT = "#{application.name} (#{application.id}) is #{to.status}";
+	private static final String DEFAULT_TEXT = "#{application.name} (#{application.id})\nstatus changed from #{from.status} to #{to.status}\n\n#{application.healthUrl}";
 
 	private final SpelExpressionParser parser = new SpelExpressionParser();
 	private final MailSender sender;

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/notify/PagerdutyNotifier.java

@@ -37,7 +37,7 @@ public class PagerdutyNotifier extends AbstractStatusChangeNotifier {
 	public static final URI DEFAULT_URI = URI
 			.create("https://events.pagerduty.com/generic/2010-04-15/create_event.json");
 
-	private final static String DEFAULT_DESCRIPTION = "#{application.name}/#{application.id} is #{to.status}";
+	private static final String DEFAULT_DESCRIPTION = "#{application.name}/#{application.id} is #{to.status}";
 
 	private final SpelExpressionParser parser = new SpelExpressionParser();
 	private RestTemplate restTemplate = new RestTemplate();