Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
apollo
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
apollo
Commits
be8cfed5
Commit
be8cfed5
authored
Jul 11, 2016
by
Jason Song
Committed by
GitHub
Jul 11, 2016
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #321 from lepdou/bugfix_0711
Bugfix update item cant lock namespace
parents
9f07d812
0138823f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
2 deletions
+12
-2
NamespaceLockAspect.java
...ramework/apollo/adminservice/aop/NamespaceLockAspect.java
+10
-0
ConfigNamespaceController.js
...ic/scripts/controller/config/ConfigNamespaceController.js
+2
-2
No files found.
apollo-adminservice/src/main/java/com/ctrip/framework/apollo/adminservice/aop/NamespaceLockAspect.java
View file @
be8cfed5
...
...
@@ -42,18 +42,28 @@ public class NamespaceLockAspect {
private
ApolloSwitcher
apolloSwitcher
;
//create item
@Before
(
"@annotation(PreAcquireNamespaceLock) && args(appId, clusterName, namespaceName, item, ..)"
)
public
void
requireLockAdvice
(
String
appId
,
String
clusterName
,
String
namespaceName
,
ItemDTO
item
)
{
acquireLock
(
appId
,
clusterName
,
namespaceName
,
item
.
getDataChangeLastModifiedBy
());
}
//update item
@Before
(
"@annotation(PreAcquireNamespaceLock) && args(appId, clusterName, namespaceName, itemId, item, ..)"
)
public
void
requireLockAdvice
(
String
appId
,
String
clusterName
,
String
namespaceName
,
long
itemId
,
ItemDTO
item
)
{
acquireLock
(
appId
,
clusterName
,
namespaceName
,
item
.
getDataChangeLastModifiedBy
());
}
//update by change set
@Before
(
"@annotation(PreAcquireNamespaceLock) && args(appId, clusterName, namespaceName, changeSet, ..)"
)
public
void
requireLockAdvice
(
String
appId
,
String
clusterName
,
String
namespaceName
,
ItemChangeSets
changeSet
)
{
acquireLock
(
appId
,
clusterName
,
namespaceName
,
changeSet
.
getDataChangeLastModifiedBy
());
}
//delete item
@Before
(
"@annotation(PreAcquireNamespaceLock) && args(itemId, operator, ..)"
)
public
void
requireLockAdvice
(
long
itemId
,
String
operator
)
{
Item
item
=
itemService
.
findOne
(
itemId
);
...
...
apollo-portal/src/main/resources/static/scripts/controller/config/ConfigNamespaceController.js
View file @
be8cfed5
...
...
@@ -276,8 +276,8 @@ application_module.controller("ConfigNamespaceController",
}
function
lockCheck
(
namespace
)
{
if
(
namespace
.
lockOwner
&&
scope
.
currentUser
!=
namespace
.
lockOwner
)
{
scope
.
lockOwner
=
namespace
.
lockOwner
;
if
(
namespace
.
lockOwner
&&
$
scope
.
currentUser
!=
namespace
.
lockOwner
)
{
$
scope
.
lockOwner
=
namespace
.
lockOwner
;
$
(
'#namespaceLockedDialog'
).
modal
(
'show'
);
return
false
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment