Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
apollo
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
apollo
Commits
967041c4
Commit
967041c4
authored
Dec 28, 2016
by
Jason Song
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
optimize instance config audit to reduce writes if the record was updated not long ago(10 minutes)
parent
ef746da7
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
0 deletions
+10
-0
InstanceConfigAuditUtil.java
...rk/apollo/configservice/util/InstanceConfigAuditUtil.java
+10
-0
No files found.
apollo-configservice/src/main/java/com/ctrip/framework/apollo/configservice/util/InstanceConfigAuditUtil.java
View file @
967041c4
...
...
@@ -36,6 +36,7 @@ public class InstanceConfigAuditUtil implements InitializingBean {
private
static
final
int
INSTANCE_CONFIG_AUDIT_MAX_SIZE
=
2000
;
private
static
final
int
INSTANCE_CACHE_MAX_SIZE
=
10000
;
private
static
final
int
INSTANCE_CONFIG_CACHE_MAX_SIZE
=
10000
;
private
static
final
long
OFFER_TIME_LAST_MODIFIED_TIME_THRESHOLD_IN_MILLI
=
TimeUnit
.
MINUTES
.
toMillis
(
10
);
//10 minutes
private
static
final
Joiner
STRING_JOINER
=
Joiner
.
on
(
ConfigConsts
.
CLUSTER_NAMESPACE_SEPARATOR
);
private
final
ExecutorService
auditExecutorService
;
private
final
AtomicBoolean
auditStopped
;
...
...
@@ -93,6 +94,10 @@ public class InstanceConfigAuditUtil implements InitializingBean {
instanceConfig
.
setConfigClusterName
(
auditModel
.
getConfigClusterName
());
instanceConfig
.
setReleaseKey
(
auditModel
.
getReleaseKey
());
instanceConfig
.
setReleaseDeliveryTime
(
auditModel
.
getOfferTime
());
}
else
if
(
offerTimeAndLastModifiedTimeCloseEnough
(
auditModel
.
getOfferTime
(),
instanceConfig
.
getDataChangeLastModifiedTime
()))
{
//when releaseKey is the same, optimize to reduce writes if the record was updated not long ago
return
;
}
//we need to update no matter the release key is the same or not, to ensure the
//last modified time is updated each day
...
...
@@ -117,6 +122,11 @@ public class InstanceConfigAuditUtil implements InitializingBean {
}
}
private
boolean
offerTimeAndLastModifiedTimeCloseEnough
(
Date
offerTime
,
Date
lastModifiedTime
)
{
return
(
offerTime
.
getTime
()
-
lastModifiedTime
.
getTime
())
<
OFFER_TIME_LAST_MODIFIED_TIME_THRESHOLD_IN_MILLI
;
}
private
long
prepareInstanceId
(
InstanceConfigAuditModel
auditModel
)
{
Instance
instance
=
instanceService
.
findInstance
(
auditModel
.
getAppId
(),
auditModel
.
getClusterName
(),
auditModel
.
getDataCenter
(),
auditModel
.
getIp
());
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment