Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
S
spring-cloud-netflix
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
spring-cloud-netflix
Commits
6f569976
Commit
6f569976
authored
Feb 06, 2015
by
Dave Syer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid NPE if discovery is not available yet
parent
06d0bbe7
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
3 deletions
+10
-3
EurekaInstanceDiscovery.java
...mework/cloud/netflix/turbine/EurekaInstanceDiscovery.java
+10
-3
No files found.
spring-cloud-netflix-turbine/src/main/java/org/springframework/cloud/netflix/turbine/EurekaInstanceDiscovery.java
View file @
6f569976
...
...
@@ -23,6 +23,7 @@ import java.util.List;
import
java.util.Map
;
import
lombok.extern.apachecommons.CommonsLog
;
import
org.springframework.expression.Expression
;
import
org.springframework.expression.spel.standard.SpelExpressionParser
;
import
org.springframework.expression.spel.support.StandardEvaluationContext
;
...
...
@@ -33,6 +34,7 @@ import com.netflix.appinfo.InstanceInfo;
import
com.netflix.appinfo.InstanceInfo.InstanceStatus
;
import
com.netflix.config.DynamicPropertyFactory
;
import
com.netflix.config.DynamicStringProperty
;
import
com.netflix.discovery.DiscoveryClient
;
import
com.netflix.discovery.DiscoveryManager
;
import
com.netflix.discovery.shared.Application
;
import
com.netflix.turbine.discovery.Instance
;
...
...
@@ -111,14 +113,19 @@ public class EurekaInstanceDiscovery implements InstanceDiscovery {
private
List
<
Instance
>
getInstancesForApp
(
String
appName
)
throws
Exception
{
List
<
Instance
>
instances
=
new
ArrayList
<
Instance
>();
log
.
info
(
"Fetching instances for app: "
+
appName
);
Application
app
=
DiscoveryManager
.
getInstance
().
getDiscoveryClient
()
.
getApplication
(
appName
);
DiscoveryClient
client
=
DiscoveryManager
.
getInstance
().
getDiscoveryClient
();
if
(
client
==
null
)
{
log
.
info
(
"Discovery client not ready for: "
+
appName
);
return
instances
;
}
Application
app
=
client
.
getApplication
(
appName
);
if
(
app
==
null
)
{
log
.
warn
(
"Eureka returned null for app: "
+
appName
);
}
List
<
InstanceInfo
>
instancesForApp
=
app
.
getInstances
();
if
(
instancesForApp
!=
null
)
{
log
.
info
(
"Received instance list for app: "
+
appName
+
" = "
+
instancesForApp
.
size
());
log
.
info
(
"Received instance list for app: "
+
appName
+
" = "
+
instancesForApp
.
size
());
for
(
InstanceInfo
iInfo
:
instancesForApp
)
{
Instance
instance
=
marshallInstanceInfo
(
iInfo
);
if
(
instance
!=
null
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment