Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
S
spring-cloud-netflix
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
spring-cloud-netflix
Commits
381a0970
Unverified
Commit
381a0970
authored
Jun 15, 2018
by
Ryan Baxter
Committed by
GitHub
Jun 15, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Does not set accept-encoding header when zuul proxies request if already…
Does not set accept-encoding header when zuul proxies request if already present. Fixes #2998 (#3011)
parent
0970a3ef
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
0 deletions
+16
-0
ProxyRequestHelper.java
...mework/cloud/netflix/zuul/filters/ProxyRequestHelper.java
+2
-0
ProxyRequestHelperTests.java
...k/cloud/netflix/zuul/filters/ProxyRequestHelperTests.java
+14
-0
No files found.
spring-cloud-netflix-core/src/main/java/org/springframework/cloud/netflix/zuul/filters/ProxyRequestHelper.java
View file @
381a0970
...
@@ -145,7 +145,9 @@ public class ProxyRequestHelper {
...
@@ -145,7 +145,9 @@ public class ProxyRequestHelper {
for
(
String
header
:
zuulRequestHeaders
.
keySet
())
{
for
(
String
header
:
zuulRequestHeaders
.
keySet
())
{
headers
.
set
(
header
,
zuulRequestHeaders
.
get
(
header
));
headers
.
set
(
header
,
zuulRequestHeaders
.
get
(
header
));
}
}
if
(!
headers
.
containsKey
(
HttpHeaders
.
ACCEPT_ENCODING
))
{
headers
.
set
(
HttpHeaders
.
ACCEPT_ENCODING
,
"gzip"
);
headers
.
set
(
HttpHeaders
.
ACCEPT_ENCODING
,
"gzip"
);
}
return
headers
;
return
headers
;
}
}
...
...
spring-cloud-netflix-core/src/test/java/org/springframework/cloud/netflix/zuul/filters/ProxyRequestHelperTests.java
View file @
381a0970
...
@@ -212,6 +212,20 @@ public class ProxyRequestHelperTests {
...
@@ -212,6 +212,20 @@ public class ProxyRequestHelperTests {
}
}
@Test
@Test
public
void
buildZuulRequestHeadersRequestsAcceptEncoding
()
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
""
,
"/"
);
request
.
addHeader
(
"accept-encoding"
,
"identity"
);
ProxyRequestHelper
helper
=
new
ProxyRequestHelper
();
MultiValueMap
<
String
,
String
>
headers
=
helper
.
buildZuulRequestHeaders
(
request
);
List
<
String
>
acceptEncodings
=
headers
.
get
(
"accept-encoding"
);
assertThat
(
acceptEncodings
,
hasSize
(
1
));
assertThat
(
acceptEncodings
,
contains
(
"identity"
));
}
@Test
public
void
setResponseLowercase
()
throws
IOException
{
public
void
setResponseLowercase
()
throws
IOException
{
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"POST"
,
"/"
);
MockHttpServletRequest
request
=
new
MockHttpServletRequest
(
"POST"
,
"/"
);
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
MockHttpServletResponse
response
=
new
MockHttpServletResponse
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment