Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
apollo
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
openSource
apollo
Commits
66c20025
Commit
66c20025
authored
Dec 22, 2016
by
张乐
Committed by
GitHub
Dec 22, 2016
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #495 from nobodyiam/optimize-client-logerror
remove unnessary Tracer.logError
parents
c91f6904
8681f84f
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
0 additions
and
5 deletions
+0
-5
ConfigServiceLocator.java
...trip/framework/apollo/internals/ConfigServiceLocator.java
+0
-1
LocalFileConfigRepository.java
...framework/apollo/internals/LocalFileConfigRepository.java
+0
-1
RemoteConfigLongPollService.java
...amework/apollo/internals/RemoteConfigLongPollService.java
+0
-1
RemoteConfigRepository.java
...ip/framework/apollo/internals/RemoteConfigRepository.java
+0
-2
No files found.
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/ConfigServiceLocator.java
View file @
66c20025
...
...
@@ -122,7 +122,6 @@ public class ConfigServiceLocator implements Initializable {
logConfigServicesToCat
(
services
);
return
;
}
catch
(
Throwable
ex
)
{
Tracer
.
logError
(
ex
);
transaction
.
setStatus
(
ex
);
exception
=
ex
;
}
finally
{
...
...
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/LocalFileConfigRepository.java
View file @
66c20025
...
...
@@ -141,7 +141,6 @@ public class LocalFileConfigRepository extends AbstractConfigRepository
m_fileProperties
=
this
.
loadFromLocalCacheFile
(
m_baseDir
,
m_namespace
);
transaction
.
setStatus
(
Transaction
.
SUCCESS
);
}
catch
(
Throwable
ex
)
{
Tracer
.
logError
(
ex
);
transaction
.
setStatus
(
ex
);
exception
=
ex
;
//ignore
...
...
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/RemoteConfigLongPollService.java
View file @
66c20025
...
...
@@ -180,7 +180,6 @@ public class RemoteConfigLongPollService implements Initializable {
transaction
.
setStatus
(
Transaction
.
SUCCESS
);
}
catch
(
Throwable
ex
)
{
lastServiceDto
=
null
;
Tracer
.
logError
(
ex
);
transaction
.
setStatus
(
ex
);
long
sleepTimeInSecond
=
m_longPollFailSchedulePolicyInSecond
.
fail
();
logger
.
warn
(
...
...
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/RemoteConfigRepository.java
View file @
66c20025
...
...
@@ -213,11 +213,9 @@ public class RemoteConfigRepository extends AbstractConfigRepository {
statusCodeException
=
new
ApolloConfigStatusCodeException
(
ex
.
getStatusCode
(),
message
);
}
Tracer
.
logError
(
statusCodeException
);
transaction
.
setStatus
(
statusCodeException
);
exception
=
statusCodeException
;
}
catch
(
Throwable
ex
)
{
Tracer
.
logError
(
ex
);
transaction
.
setStatus
(
ex
);
exception
=
ex
;
}
finally
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment